change default status check timeout to 10 minutes #5247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5247 +/- ##
=======================================
Coverage 71.86% 71.86%
=======================================
Files 388 388
Lines 14051 14051
=======================================
Hits 10098 10098
Misses 3207 3207
Partials 746 746
Continue to review full report at Codecov.
|
briandealwis
approved these changes
Jan 20, 2021
|
Thanks for this fix :) @MarlonGamez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5106
Description
Changes the default timeout of status check to 10 minutes, according to conversation on #5106
User facing changes (remove if N/A)
Users deploying with skaffold using status-check will have a longer period of time before their deployment times out